-
Notifications
You must be signed in to change notification settings - Fork 759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block consensus methods refactoring #3571
Conversation
…ndalone functions
…reumjs/ethereumjs-monorepo into block-consensus-methods-refactoring
Testing the bundle size with a standard code path:
before: 325.8kb |
Taking a look at the output bundle, it seems like some of the consensus functions are still being included in the final output bundle, will have to look into why this is happening as the code path doesn't seem to use them. |
…to block-consensus-methods-refactoring
…reumjs/ethereumjs-monorepo into block-consensus-methods-refactoring
Nice, this looks great now! 🤩 |
(interesting failure in client tests though) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Further comments have confirmed that the code is good now.
Ah, looking through this I have to say, this feels really good to have this consensus code and this specific methods out of core Block, also changes all look good, had a final look over the code changes! Thanks Amir, nice work! 👍 🙂 |
This change reforms certain consensus-related
Block
andBlockHeader
class methods into standalone functions, as proposed in #3563.